Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --prefer-binary option in requirements file #7996

Merged
merged 3 commits into from
May 23, 2020
Merged

Allow --prefer-binary option in requirements file #7996

merged 3 commits into from
May 23, 2020

Conversation

deveshks
Copy link
Contributor

@deveshks deveshks commented Apr 8, 2020 •
edited
Loading

Fixes and closes #7693 .

Adds the --prefer-binary options as a supported option in requirements.txt

Something like

--prefer-binary

<packages>
....

I saw that the PR #5370 which introduced this behaviour had some tests. I have replicated those tests with a requirements.txt file.

@deveshks deveshks force-pushed the add-prefer-binary-to-req-file branch from 7c28953 to 0afdc82 Compare April 8, 2020 04:22
@deveshks deveshks changed the title Allow --prefix-binary option in requirements file Allow --prefer-binary option in requirements file Apr 8, 2020
@deveshks deveshks force-pushed the add-prefer-binary-to-req-file branch from 0afdc82 to 6e048b2 Compare April 8, 2020 15:32
@deveshks deveshks mentioned this pull request Apr 8, 2020
Closed
@deveshks
Copy link
Contributor Author

Hi @pradyunsg

Could you please take a look at this PR and suggest if this is the correct way of handling --prefer-binary, and the corresponding tests, and any additional suggestions for improving this?

@deveshks
Copy link
Contributor Author

Can I get this PR reviewed?

pradyunsg
pradyunsg approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

news/7693.feature Outdated Show resolved Hide resolved
@deveshks deveshks force-pushed the add-prefer-binary-to-req-file branch from 444befb to a0c2168 Compare April 25, 2020 04:32
@deveshks
Copy link
Contributor Author

If there are no more changes necessary to be done in this PR, may I get this merged?

@deveshks deveshks force-pushed the add-prefer-binary-to-req-file branch from a0c2168 to ebf27ee Compare May 21, 2020 14:08
@pradyunsg pradyunsg added C: requirement file Using `requirements.txt` type: enhancement Improvements to functionality labels May 23, 2020
@pradyunsg pradyunsg merged commit 403310e into pypa:master May 23, 2020
@deveshks deveshks deleted the add-prefer-binary-to-req-file branch May 23, 2020 11:54
This was referenced May 25, 2020
Merged
Merged
@deveshks deveshks mentioned this pull request May 29, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
C: requirement file Using `requirements.txt` type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow --prefer-binary option in requirements file
2 participants
@deveshks @pradyunsg